Port the Memoize view into xilem_core #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-uk1
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the memoize view into xilem_core as macro.
I haven't added documentation yet (this could probably be its own PR I think...), it's basically just a copy of the original prototype, adjusted to be compilable again.
I've added two functions, one for a static view and one that just wraps the
Memoizeview (see it in action e.g. here or here)I guess these extra functions (including their names) are likely a point to discuss still. Especially the static view function could probably be a macro (but I think the syntactic sugar benefits are marginal, by avoiding the extra closure)